feat(php): add agent installation logic to operator #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 47.43% 47.43%
=======================================
Files 13 13
Lines 976 976
=======================================
Hits 463 463
Misses 448 448
Partials 65 65 ☔ View full report in Codecov by Sentry. |
mfulb
reviewed
Aug 2, 2024
mfulb
reviewed
Aug 2, 2024
dbudziwojskiNR
approved these changes
Aug 28, 2024
dbudziwojskiNR
requested review from
a team
and removed request for
a team and
lavarou
mfulb
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the PHP Agent Operator.
For PHP, we need to emulate some of the aspects of the typical
newrelic-install.shscript that the base PHP agent relies on in order to avoid having to inject commands into the application container itself. This logic requires the addition of an annotation (unique to PHP) that requires the user to define the PHP version of the application they intend to instrument. The installation logic will be handled in the initContainer itself, installing the appropriate agent and daemon artifacts, configuration file, and log directories in the shared volume/newrelic-instrumentation. When the application pod starts up, thePHP_INI_SCAN_DIRvariable will be injected from the operator into the application container which will instruct the PHP binary on the customer system to search for the INI in the shared volume created by the initContainer, allowing for instrumentation.Type of change
Checklist: